Bump Microsoft.SqlServer.DacFx to 170.5.80-preview - #2808
Conversation
Picks up the DacFx fix for Table Designer publish previews, which showed default constraints being dropped without showing them being recreated even though the generated script did recreate them.
|
As part of updating the dependencies in Packages.props we require that any PRs opened also verify that Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR
|
There was a problem hiding this comment.
Pull request overview
Updates the centrally managed NuGet dependency version for Microsoft.SqlServer.DacFx to pick up the Table Designer publish preview fix (default constraints drop/recreate preview correctness) without changing any service code.
Changes:
- Bump
Microsoft.SqlServer.DacFxfrom170.5.60-previewto170.5.80-previewinPackages.props.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
The PR description claims a single-line DacFx bump, but the diff also updates ScriptDom and needs scope/intent clarified (or the extra change reverted).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
| <PackageReference Update="Microsoft.SqlServer.Management.SqlParser" Version="180.4.0" /> | ||
| <PackageReference Update="Microsoft.SqlServer.TransactSql.ScriptDom" Version="180.78.1" /> | ||
| <PackageReference Update="Microsoft.SqlServer.TransactSql.ScriptDom" Version="180.102.0" /> |
Description
Bumps
Microsoft.SqlServer.DacFxfrom170.5.60-previewto170.5.80-previewto pick up the fix for the Table Designer publish preview, which showed default constraints being dropped without showing them being recreated, even though the generated script did recreate them.One line in
Packages.props; no source changes.Microsoft.SqlServer.DacFx.Projectsis left at0.6.24-preview.Fixes microsoft/vscode-mssql#21132
Code Changes Checklist
dotnet test) — could not be run locally, see Additional NotesReviewers: Please read our reviewer guidelines